This repository was archived by the owner on Nov 19, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Updated Cloud Guide navigation for accessible Docker launch instructions #6620
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
accessible: - Added the Docker Development > Launch Docker navigation heading - Changes the top-level navigation title from "Launch Docker" to "Configure and launch Docker" - Updated the Launch developer and Launch production topics to include links to the Docker configuration topics - Changed title of "Launch modes" subsection to add what launch modes are for
Cloud Guide_ to include new requirement to specify `--with-cron` option to build a Magento Cloud Docker environment that includes a Cron container.
hguthrie
suggested changes
Feb 12, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some links could be improved and the Launch modes title seems bloated and not very useful.
hguthrie
approved these changes
Feb 13, 2020
running tests |
running tests |
Hi @meker12, thank you for your contribution! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
2.x
Editorial
Typo and grammar fixes or minor rewrites to correct inaccuracies
Internal Dev
Differentiates work between community and Magento staff
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
Make Docker Launch instructions more accessible:
"Configure and launch Docker"
links to the Docker configuration topics
are for == "Launch modes for configuring the Docker environment"
Affected DevDocs pages